Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 49: adding old SolCache JS sample #54

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aaron-613
Copy link
Contributor

@TamimiGitHub could probably use your help here..? @solace-dmckay dug up the old SolCache JS sample that used to be included with the old (pre-Guaranteed-messaging?) API. I've pushed it into a new branch, and also included a rough working sample I hacked together from the TopicSubscriber sample.

Looking briefly at the code, the old SolCache sample uses jquery, and I don't think our new ones do. Perhaps this is something we can get the API team to help with, but thought I'd give you a crack first..?

@aaron-613
Copy link
Contributor Author

⚠ NOTE: this branch is not ready to be MERGED, at all. Needs some work. Just checking in for collaboration.

@TamimiGitHub
Copy link
Contributor

A couple of notes:

  • Not sure why you included sol-cache.js and sol-cache-ui.js? couldnt you just use the createCacheSession from the solace client API
var cs = client.session.createCacheSession({
          cacheName: 'dc1',
          maxAgeSec: 25000,
          maxMessages: 1,
          timeoutMsec: 10000 
        });
  • What old SolCache sample are you referring to? We dont need jquery for a simple html landing page. The other samples here dont use it

Happy to look at this further

@aaron-613
Copy link
Contributor Author

Hey. Doing cleanup and stuff.

  • the old SolCache sample that Dave was asking for used to be bundled with the API years ago. It's the index.html, sol-cache*.js. It's super old, uses jQuery, looks super out-of-date.
  • the working-rough-sample.html I made. But it's not pretty

All the newer JS samples use basic HTML & JS, and pure.css for styling. Wondering if we go about that route, trying to hack/salvage the GUI elements and put them into the same format as other other newer samples?

@aaron-613 aaron-613 marked this pull request as draft April 20, 2022 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants